-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Portal-Hive client-interop fixes #429
Conversation
Currently Should be fixable on Ultralight side. The failure has to do with Ultralight's uTP should know to wait for all data packets before compiling the stream, but the current solution for that is insufficient. Personally in favor of merging this PR to update the public Portal-Hive tests. The fix for above can be done in a new PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR will bring the portal hive client interop tests to
100%98% passing.findENR
functions now usegetWithPending
, which will return the peerId of peers still in the discv5pending
buffer.sndId
/rcvId
/connectionId
setupseqNr
/ackNr
setupFIN
handling.