Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EthJS dependencies to new breaking releases #433

Merged
merged 20 commits into from
Aug 11, 2023

Conversation

acolytec3
Copy link
Collaborator

@acolytec3 acolytec3 commented Aug 9, 2023

Updates all of the EthJS deps to the newest release, also updates discv5 to v5.0.1, a linter dep, and also generally tries to move everything away from buffer as much as possible.

And...it also disables the browser client until we decide what to do with the waku stuff. Since that's all kinds of broke right now.

@holgerd77
Copy link
Member

How is it going here? 🙂 Any surprises?

@acolytec3
Copy link
Collaborator Author

I found a missing dep declaration in discv5 but nothing directly related to EthereumJS at the moment.

@acolytec3 acolytec3 marked this pull request as ready for review August 10, 2023 18:52
Copy link
Collaborator

@ScottyPoi ScottyPoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

force-push fight!!

LGTM!

Reverted the last commit re: getSocketAddress due to import issues.
merging now

@ScottyPoi ScottyPoi merged commit ee0ff79 into master Aug 11, 2023
4 checks passed
@holgerd77
Copy link
Member

Ugh, but definitely also no small PR here, right? 🤔

@acolytec3
Copy link
Collaborator Author

No. 😬 The buffer to uint8array conversation was the biggest part, and some of the buffer to bytes helpers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants