Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add province false to docker-image.yml #493

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

KolbyML
Copy link
Contributor

@KolbyML KolbyML commented Oct 30, 2023

Province is currently on and this is causing

{
   "schemaVersion": 2,
   "mediaType": "application/vnd.oci.image.index.v1+json",
   "manifests": [
      {
         "mediaType": "application/vnd.oci.image.manifest.v1+json",
         "size": 2201,
         "digest": "sha256:dc619ad32dd5ac9afee36495d5f4fa683e3af6af26c0288cc52bcf347ce160e0",
         "platform": {
            "architecture": "amd64",
            "os": "linux"
         }
      },
      {
         "mediaType": "application/vnd.oci.image.manifest.v1+json",
         "size": 567,
         "digest": "sha256:e31579f8e5e6e75cbafbbd1e339c77235d04ecc4adbd4b3ee28c8eab2560847d",
         "platform": {
            "architecture": "unknown",
            "os": "unknown"
         }
      }
   ]
}

"unknown" to be added

Which is apparently causing
{"errors":[{"code":"MANIFEST_UNKNOWN","message":"OCI index found, but Accept header does not support OCI indexes"}]}

I found a proposed solution here
docker/buildx#1509 (comment)

Which is what I added

@KolbyML
Copy link
Contributor Author

KolbyML commented Oct 30, 2023

@acolytec3 ping for review

@acolytec3
Copy link
Collaborator

@KolbyML does this solve your issue? I'm not 100% clear what is being solved by this fix.

@KolbyML
Copy link
Contributor Author

KolbyML commented Oct 30, 2023

@acolytec3 Well I can't test if it does till this is deployed

Copy link
Collaborator

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acolytec3 acolytec3 merged commit 9006773 into ethereumjs:master Oct 30, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants