Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseNetwork: unbind client methods #627

Merged
merged 2 commits into from
Sep 18, 2024
Merged

BaseNetwork: unbind client methods #627

merged 2 commits into from
Sep 18, 2024

Conversation

ScottyPoi
Copy link
Collaborator

Removes final remaining bind instances from BaseNetwork constructor.

bind was used to connect PortalNetwork class methods to BaseNetwork methods efficiently, but is an undesirable approach for various reasons, including the ability to read and navigate the codebase in Visual Studio Code using hyperlinks.

The bind approach was replaced by wrapper methods in the BaseNetwork class. No downstream changes were needed, as the names and API of the methods remain the same. The change is purely aesthetic.

Copy link
Collaborator

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bout time

@acolytec3
Copy link
Collaborator

` but is an undesirable approach for various reasons, including the ability to read and navigate the codebase in Visual Studio Code using hyperlinks.

Let's be honest. I just don't like .bind cuz it stinks ;-)

@acolytec3 acolytec3 merged commit 6c4d0c2 into master Sep 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants