BaseNetwork: unbind client methods #627
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes final remaining
bind
instances fromBaseNetwork
constructor.bind
was used to connectPortalNetwork
class methods toBaseNetwork
methods efficiently, but is an undesirable approach for various reasons, including the ability to read and navigate the codebase in Visual Studio Code using hyperlinks.The
bind
approach was replaced by wrapper methods in theBaseNetwork
class. No downstream changes were needed, as the names and API of the methods remain the same. The change is purely aesthetic.