Reduce bytes / hex conversions of content keys #628
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Excessive need to use
hexToBytes
andbytesToHex
conversion methods oncontentKey
,contentId
,blockHash
, and more.Cause:
Inconsistent design of functions. Some functions expected keys to be strings, others expected Uint8Arrays.
Solution:
Internally,
contentKeys
should always beUint8Array
, with the only conversion to and from strings happening in the DB manager.contentId
should always be an unprefixed hex string, matching the type ofenr.nodeId
, and the expected input of the imported distance functiondistance(nodeId, contentId)