Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

portalnetwork: return closer ENRs #630

Closed
wants to merge 1 commit into from
Closed

portalnetwork: return closer ENRs #630

wants to merge 1 commit into from

Conversation

ScottyPoi
Copy link
Collaborator

Adds a filter to the ENR response to FINDCONTENT

Response should only include ENR's closer than our own.

acolytec3
acolytec3 reviewed Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe add a test to confirm it's working right and then go ahead and merge!

@ScottyPoi
Copy link
Collaborator Author

This is tested in history-mesh hive tests.
These tests pass before this PR, and currently fail on this branch.

do-not-merge until resolved

@ScottyPoi
Copy link
Collaborator Author

Closing without merging. I do not believe this is a correct change.

@ScottyPoi ScottyPoi closed this Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acolytec3 acolytec3 acolytec3 left review comments

Assignees
No one assigned
Labels
do-not-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ScottyPoi @acolytec3