Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch all hex to bytes conversions to ethjs equivalents #632

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Switch all hex to bytes conversions to ethjs equivalents #632

wants to merge 1 commit into from

Conversation

alivia-g
Copy link

fixes #624

@acolytec3
Copy link
Collaborator

Thanks for the PR. I'm not 100% sure what all you were working on here but this shouldn't require updating any dependencies (notably eslint and related plugins) and there should be no updates to docs. This is purely changing the fromHexString/toHexString methods over to the equivalents from @ethereumjs/util. We won't be able to take this in without removing all the extra stuff.

Notably, if you want to continue with this, it should be pretty close a simple "find/replace" across 3 main packages (portalnetwork, cli, era).

Let me know if you want to continue on this one.

@alivia-g
Switch all hex to bytes conversions to ethjs equivalents
14a6cb5 
fixing tests

Revert "Switch all hex to bytes conversions to ethjs equivalents"

This reverts commit 040ff32933c5a9fb178d224c71f793fc25e2f1da.
@alivia-g
Copy link
Author

I will continue working on this one, thank you for explaining.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch all hex to bytes conversions to ethjs equivalents
2 participants
@alivia-g @acolytec3