Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch all hex to bytes conversions to ethjs equivalents #632

Closed
wants to merge 4 commits into from

Commits on Sep 29, 2024

  1. Configuration menu
    Copy the full SHA
    2c3b7b0 View commit details
    Browse the repository at this point in the history
  2. Switch all hex to bytes conversions to ethjs equivalents

    fixing tests
    
    Revert "Switch all hex to bytes conversions to ethjs equivalents"
    
    This reverts commit 040ff32933c5a9fb178d224c71f793fc25e2f1da.
    alivia-g committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    a1c682f View commit details
    Browse the repository at this point in the history
  3. hold

    alivia-g committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    a3db2aa View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. passing tests

    Currently passing portalnetwork test and integration test, cli test still have 1 failed test. I'm not sure how to proceed from here.
    
    Here is the failed cli test case:
    ```
     FAIL  test/rpc/portal/beaconLocalContent.spec.ts > portal_beaconLocalContent tests > should not find any local content
    AssertionError: expected -32603 to equal -32009
    
    - Expected
    + Received
    
    - -32009
    + -32603
    
     ❯ test/rpc/portal/beaconLocalContent.spec.ts:20:12
         18|       ),
         19|     ])
         20|     assert.equal(res.error.code, -32009)
           |            ^
         21|     ultralight.kill(9)
         22|   }, 10000)
    ```
    alivia-g committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    e4dc832 View commit details
    Browse the repository at this point in the history