Beacon: fix Enr Response #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottyPoi
force-pushed
the
enr-response
branch
from
8604a52
to
a93b2b7
Compare
ScottyPoi
force-pushed
the
enr-response
branch
from
a93b2b7
to
3e8e209
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Beacon Network
handleFindContentBeacon Network implementation of
handleFindContentdid not repond with ENR's when content was not found. Instead it would reply with an empty byte array.This PR extracts the ENR response code from
network.handleFindContentinto a separate methodenrResponse, and replaces the code withinhandleFindContentwith the new method.We also fix Beacon by injecting this new method into
beacon.handleFindContentThis fixes
Beacon-Interophive tests Find Content - content not found