Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ContentLookup followup: fix uTP dstId value #665

Merged
merged 3 commits into from
Oct 31, 2024
Merged

ContentLookup followup: fix uTP dstId value #665

merged 3 commits into from
Oct 31, 2024

Conversation

ScottyPoi
Copy link
Collaborator

Fixes uTP response to sendFindContent

sendFindContent can work with either a nodeId or ENR string.

However, uTP.handleNewRequest requires a nodeId, and not an ENR string.

This updates the call to .handleNewRequest by ensuring that enr.nodeId is passed, instead of passing the same string passed to sendFindContent

acolytec3
acolytec3 approved these changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ScottyPoi ScottyPoi merged commit 7cd1de5 into master Oct 31, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acolytec3 acolytec3 acolytec3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ScottyPoi @acolytec3