Fix overflow issues in seqNr
and ackNr
#692
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #691.
The Problem
uTP sequence numbers are 16 bit unsigned integers so have a range of 0-65535. When a sequence number reaches the maximum value, we would expect the next sequence number to be 0. Ultralight was not checking for overflow and blithely continuing on in the sequence since we are using native Javascript
numbers
in our code rather than true 16-bit intengers.Solution
contentWriter
sodataChunks
are stored in an array of tuples of the form[seqNr, bytes]
rather than an object keyed by theseqNr
Object.keys
code to simple Array accesses (which should provide some small performance boost)writeSocket.dataNrs
as unnecessary