Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalized branches are not handled well #40

Open
ericwa opened this issue Jan 27, 2016 · 0 comments
Open

Finalized branches are not handled well #40

ericwa opened this issue Jan 27, 2016 · 0 comments
Labels
bug core

Comments

@ericwa
Copy link
Member

ericwa commented Jan 27, 2016

See commit: 301824e which fixes the worst problem, after finalization, the COBranch object was returning NO for -isDeleted.

But we still don't handle it well at all. The COBranch object should be removed from the COPersistentRoot's branch dictionary and turn into a "zombie", following the same pattern we use elsewhere.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@qmathe @ericwa