Skip to content

Commit

Permalink
♻️ Remove repeat argument
Browse files Browse the repository at this point in the history
`this._renderingFrame` is already used instead of it.
  • Loading branch information
clabe45 committed Jul 17, 2023
1 parent b4d3353 commit 03d4416
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/movie/movie.ts
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ export class Movie {
await new Promise<void>(resolve => {
if (!this.renderingFrame) {
// Not rendering (and not playing), so play.
this._render(true, undefined, resolve)
this._render(undefined, resolve)
}

// Stop rendering frame if currently doing so, because playing has higher
Expand Down Expand Up @@ -400,7 +400,7 @@ export class Movie {
* @param [done=undefined] - Called when done playing or when the current
* frame is loaded
*/
private _render (repeat, timestamp = performance.now(), done = undefined) {
private _render (timestamp = performance.now(), done = undefined) {
clearCachedValues(this)

if (!this.rendering) {
Expand Down Expand Up @@ -505,7 +505,7 @@ export class Movie {

// TODO: Is making a new arrow function every frame bad for performance?
window.requestAnimationFrame(() => {
this._render(repeat, undefined, done)
this._render(undefined, done)
})
}

Expand Down Expand Up @@ -624,7 +624,7 @@ export class Movie {

return new Promise(resolve => {
this._renderingFrame = true
this._render(false, undefined, resolve)
this._render(undefined, resolve)
})
}

Expand Down

0 comments on commit 03d4416

Please sign in to comment.