🚸 Split audio source validation (#238)

Closes #216
etro-js · Aug 25, 2023 · 0869db3 · 0869db3
1 parent fbb3991
commit 0869db3
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/layer/audio-source.ts b/src/layer/audio-source.ts
@@ -85,9 +85,12 @@ function AudioSourceMixin<OptionsSuperclass extends BaseOptions> (superclass: Co
       applyOptions(options, this)
 
       const load = () => {
-        // TODO:              && ?
-        if ((options.duration || (this.source.duration - this.sourceStartTime)) < 0) {
-          throw new Error('Invalid options.duration or options.sourceStartTime')
+        if (options.duration < 0) {
+          throw new Error('Invalid options.duration. It must be a non-negative value.')
+        }
+
+        if (this.sourceStartTime > this.source.duration) {
+          throw new Error('options.sourceStartTime cannot exceed options.source.duration')
         }
 
         this._unstretchedDuration = options.duration || (this.source.duration - this.sourceStartTime)