Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Remove credential response property "format" #72

Conversation

srosenda
Copy link
Contributor

@srosenda srosenda commented Aug 6, 2024

"format" is not a specified parameter of OpenID4VCI Credential Response: https://openid.net/specs/openid-4-verifiable-credential-issuance-1_0.html#name-credential-response.

Fixes #71.

Description of change

Remove unspecified optional property "format" from data structures that decode credential responses. The property value was always nil and it was not used for anything.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Project's automated test suite passes.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the readme
  • My changes generate no new warnings
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@srosenda srosenda requested a review from a team as a code owner August 6, 2024 12:36
@dtsiflit dtsiflit merged commit 691c4b6 into eu-digital-identity-wallet:main Aug 13, 2024
3 checks passed
@srosenda srosenda deleted the refactor/remove-format-in-credential-response branch October 24, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Credential Response data types have unspecified optional parameter "format"
2 participants