Evarisk#3982 [RiskAssessment] fix: make sure each risk has distinct a…

…ppliedOn

In PHP, when you add an object to an array, the array holds a reference to that object, not a copy of it. So if you modify the object afterward, all references to that object reflect those changes.
To fix this, you need to clone the object before modifying it and adding it to the $risks array. This ensures that each entry in $risks is a separate object, and modifying one does not affect the others.

class/riskanalysis/risk.class.php

@@ -307,9 +307,10 @@ public function fetchRisksOrderedByCotation($parent_id, $get_children_data = fal
 							foreach ($digiriskElementOfEntity->linkedObjectsIds['digiriskdolibarr_risk'] as $sharedRiskId) {
 								$sharedRisk = $riskList[$sharedRiskId];
 								if (is_object($sharedRisk)) {
-									$sharedRisk->appliedOn = $digiriskElementOfEntity->id;
-									$risks[] = $sharedRisk;
-								}
+                                    $clonedRisk = clone $sharedRisk;
+                                    $clonedRisk->appliedOn = $digiriskElementOfEntity->id;
+                                    $risks[] = $clonedRisk;
+                                }
 							}
 						}
 					}