Support nullable foreign keys with read_only=False #25

fabricemarie · 2018-09-24T13:44:43Z

No description provided.

evenicoulddoit

Thanks for doing this. Just one little gripe with the code, but also, I think this feature needs to be tested 👍

evenicoulddoit · 2018-09-30T17:18:52Z

rest_framework_serializer_extensions/serializers.py

@@ -545,6 +545,8 @@ def get_expand_id_field(self, field_name, field_definition):
                utils.model_from_definition(field_definition['id_model'])
                .objects.all()
            )
+        if 'allow_null' in field_definition.keys():


Wouldn't this be better as field_definition.get('allow_null')?

Support nullable foreign keys with read_only=False

2d139a2

evenicoulddoit reviewed Sep 30, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support nullable foreign keys with read_only=False #25

Support nullable foreign keys with read_only=False #25

fabricemarie commented Sep 24, 2018

evenicoulddoit left a comment

evenicoulddoit Sep 30, 2018

Support nullable foreign keys with read_only=False #25

Are you sure you want to change the base?

Support nullable foreign keys with read_only=False #25

Conversation

fabricemarie commented Sep 24, 2018

evenicoulddoit left a comment

Choose a reason for hiding this comment

evenicoulddoit Sep 30, 2018

Choose a reason for hiding this comment