Fix forward to no route targets #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garw
force-pushed
the
fix_forward_to_noroute
branch
2 times, most recently
from
6280baf
to
91dab18
Compare
Delayed forwards cause another fork rank to be created. However, it might be that the forward target isn't reachable and has no route. In this case, the forward should be dropped and not added as fork rank. This commit fixes this and adds a regression test.
Release ywsd version 0.13.0. Unfortunately, aiopg is incompatible with sqlalchemy 2. For now, we pin sqlalchemy to version 1.x and attempt to migrate to native async support of sqlalchemy 2 later.
garw
force-pushed
the
fix_forward_to_noroute
branch
from
91dab18
to
e996b9b
Compare
zivillian
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delayed forwards cause another fork rank to be created. However, it might be that the forward target isn't reachable and has no route. In this case, the forward should be dropped and not added as fork rank. This commit fixes this and adds a regression test.