2199 feature adding some additional features in kanban #2201
Conversation
|
@evereq Sir please merge this PR |
| @@ -21,23 +29,23 @@ function getStyle(provided: DraggableProvided, style: any) { | |||
| }; | |||
| } | |||
|
|
|||
| function setCommentIconColor(commentType: 'tagged' | 'untagged') { | |||
| let style; | |||
| // function setCommentIconColor(commentType: 'tagged' | 'untagged') { | |||
There was a problem hiding this comment.
@Anishali2 why this code commented out? Why we had it you think, how you replaced it?
There was a problem hiding this comment.
Let me check this
| <div className="flex flex-row items-center justify-center rounded-full w-5 h-5 z-10 bg-[#e5e7eb] dark:bg-[#181920] absolute top-0 right-0"> | ||
| <div | ||
| className="w-3.5 h-3.5 rounded-full" | ||
| style={setCommentIconColor(item.hasComment)} |
There was a problem hiding this comment.
@Anishali2 why this commented out!?
There was a problem hiding this comment.
Sorry I've forget to uncomment this let me check it again
There was a problem hiding this comment.
Sir there is an condition exist item.hasComment but when i added the types , item.hasComment is not exist so maybe I removed this because of that
I've changed the condition from hasComment to issueType but it's not the perfect I'll create the new issue for that and make it looks good
| <div className="col-span-3 flex flex-col gap-5 grow w-full"> | ||
| {item.tags && <TagList tags={item.tags} />} | ||
|
|
||
| <div className="flex flex-row flex-wrap text-wrap items-center text-sm not-italic font-semibold"> |
There was a problem hiding this comment.
@Anishali2 why you removed Issue Status, link etc? i.e. all those lines!? Or you moved them somewhere?
There was a problem hiding this comment.
Noting is removed I just aligned the css a little bit because there is so much unused css there
So there are components that changes some position that's why it is changed
|
|
||
| return ( | ||
| <section | ||
| href={``} | ||
| isDragging={isDragging} |
There was a problem hiding this comment.
We had that isDragging and isGroupedOver before, why you don't need it anymore?
There was a problem hiding this comment.
Yes I removed that because it's not the valid jsx
There was a problem hiding this comment.
Sir please check by your self when you go to this file it throughs these errors and saying
href is not exist in section
isDragging is not exist in section
etc
|
Sir please review |
evereq
deleted the
2199-feature-adding-some-additional-features-in-kanban
branch
Added the 3 dots dropdown in kanban section