-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] builds errors and warnings #2982
Changes from 10 commits
3a8d759
1f3d2c5
2b0b4db
d1b839a
6d1c6ea
ee1036b
3e88e5e
81ceefd
bbedcdc
2e65ddc
74f5b0b
b92321e
2524923
08cbb22
f16eef5
8592a26
a90e966
0e13178
11427a0
8fc3720
60e8916
92e74ad
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -48,7 +48,7 @@ export function useScrollPagination<T>({ | |
setPage(1); | ||
setSlicedItems(items.slice(0, defaultItemsPerPage)); | ||
} | ||
}, [enabled, items]); | ||
}, [enabled, items, defaultItemsPerPage]); | ||
|
||
useEffect(() => { | ||
const container = $scrollableElement.current; | ||
|
@@ -68,7 +68,7 @@ export function useScrollPagination<T>({ | |
return () => { | ||
container.removeEventListener('scroll', handleScroll); | ||
}; | ||
}, [$scrollableElement.current, enabled]); | ||
}, [enabled]); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we should leave the useEffect dependencies as they were, since we need to re-execute the useEffact function if Check the line 44 Let's keep it like this [$scrollableElement.current, enabled] |
||
|
||
useEffect(() => { | ||
const newItems = items.slice(0, defaultItemsPerPage * page); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -112,7 +112,7 @@ function useLocalTimeCounter(timerStatus: ITimerStatus | null, activeTeamTask: I | |
return 0; | ||
} | ||
return timerSecondsRef.current; | ||
}, [seconds, firstLoad, timerStatusRef]); | ||
}, [seconds, timerStatusRef]); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's uncomment the line 107 and add 107 // if (!firstLoad) return 0; |
||
|
||
useEffect(() => { | ||
if (firstLoad) { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GedeonTS
Is it possible to separate this text in the translation files?