Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/init rebranding server web #2993

Merged
merged 8 commits into from
Sep 15, 2024
Merged

Conversation

syns2191
Copy link
Collaborator

@syns2191 syns2191 commented Sep 8, 2024

Description

Please include a summary of the changes and the related issue.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Previous screenshots

Please add here videos or images of previous status

Current screenshots

Please add here videos or images of previous status

Copy link

socket-security bot commented Sep 8, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@evereq
Copy link
Member

evereq commented Sep 10, 2024

@syns2191 it's not finished yet?

@syns2191 syns2191 marked this pull request as ready for review September 15, 2024 16:58
Copy link

Report too large to display inline

View full report↗︎

@@ -0,0 +1,108 @@
import { DesktopEnvirontmentContentFactory } from './desktop-environtment-content-factory';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@syns2191 typo in environtment, fix in next PR. Make sure you are using VS Code extension to see such typos and fix before commits!

@evereq evereq merged commit cb29513 into develop Sep 15, 2024
12 of 13 checks passed
@evereq evereq deleted the feat/init-rebranding-server-web branch September 15, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants