Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark mode #750

Closed
mcrascal opened this issue Apr 12, 2023 · 4 comments
Closed

Dark mode #750

mcrascal opened this issue Apr 12, 2023 · 4 comments
Labels
ui/components Components that are not data viz ui/data Charts, tables and other viz

Comments

@mcrascal
Copy link
Member

Global dark mode:

  • Toggle in header (defaults to system, options for dark or light)
  • Dark presets in echarts theme
@mcrascal mcrascal added ui/components Components that are not data viz ui/data Charts, tables and other viz design-system labels Apr 12, 2023
@nidhi-kala
Copy link
Contributor

If this is available, I can begin working on it. Might need a few pointers on the overall design (colors, toggle button design etc) for dark mode.

@mcrascal
Copy link
Member Author

@nidhi-kala, this one's not quite ready to go yet -- I think we should tackle this after #738

@nidhi-kala
Copy link
Contributor

Sounds good. 👍

@zachstence
Copy link
Member

Closing in favor of #2499

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ui/components Components that are not data viz ui/data Charts, tables and other viz
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

750-dark-mode evidence-dev/evidence
3 participants
@mcrascal @zachstence @nidhi-kala