Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme Support #2520

Merged
merged 38 commits into from
Sep 19, 2024
Merged

Theme Support #2520

merged 38 commits into from
Sep 19, 2024

Conversation

zachstence
Copy link
Member

@zachstence zachstence commented Sep 10, 2024

Description

Adds support for a dark theme, and customization of light/dark themes

Does not include any work to replace hardcoded colors (e.g. text-green-500) with semantic color tokens (e.g. text-success).

2024-09-17.14-07-19.mov

Checklist

  • For UI or styling changes, I have added a screenshot or gif showing before & after
  • I have added a changeset
  • I have added to the docs where applicable
  • I have added to the VS Code extension where applicable

@zachstence zachstence self-assigned this Sep 10, 2024
@zachstence zachstence linked an issue Sep 10, 2024 that may be closed by this pull request
Copy link

changeset-bot bot commented Sep 10, 2024

🦋 Changeset detected

Latest commit: 743db1e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@evidence-dev/tailwind Patch
@evidence-dev/sdk Patch
@evidence-dev/core-components Patch
my-evidence-project Patch
@evidence-dev/evidence Patch
@evidence-dev/components Patch
evidence-test-environment Patch
@evidence-dev/component-utilities Patch
e2e-spa Patch
e2e-themes Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2024 3:27pm
next-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2024 3:27pm

Copy link

netlify bot commented Sep 10, 2024

Deploy Preview for evidence-test-env ready!

Name Link
🔨 Latest commit 743db1e
🔍 Latest deploy log https://app.netlify.com/sites/evidence-test-env/deploys/66ec40d20aaf57000876f70c
😎 Deploy Preview https://deploy-preview-2520--evidence-test-env.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 10, 2024

Deploy Preview for next-docs-evidence ready!

Name Link
🔨 Latest commit 743db1e
🔍 Latest deploy log https://app.netlify.com/sites/next-docs-evidence/deploys/66ec40d25ef8c20008f44faa
😎 Deploy Preview https://deploy-preview-2520--next-docs-evidence.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 10, 2024

Deploy Preview for evidence-development-workspace ready!

Name Link
🔨 Latest commit 743db1e
🔍 Latest deploy log https://app.netlify.com/sites/evidence-development-workspace/deploys/66ec40d2b4bcd80007f8c4f7
😎 Deploy Preview https://deploy-preview-2520--evidence-development-workspace.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Dots,
Table,
Prompt,
Sun,
Copy link
Member

@archiewood archiewood Sep 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add Sparkles for system?

Copy link
Member

@archiewood archiewood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works with both system wide and browser-level dark / light / system toggles 👍🏼

CleanShot.2024-09-17.at.21.30.19.mp4

Something about this seems like the text in the two labels "Appearance System" seems misaligned. I think the "System" either needs to be exactly the same text size, or else a size down from current

CleanShot 2024-09-17 at 21 18 35

Copy link
Member

@ItsMeBrianD ItsMeBrianD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good me. Do we need tests for any of this?

@zachstence
Copy link
Member Author

This looks good me. Do we need tests for any of this?

I created e2e/themes which tests the whole flow. I feel there isn't much logic to unit test, I think the E2E test covers it pretty well

@ItsMeBrianD
Copy link
Member

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Theming
3 participants