-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme Support #2520
Theme Support #2520
Conversation
🦋 Changeset detectedLatest commit: 743db1e The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for evidence-test-env ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for next-docs-evidence ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for evidence-development-workspace ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
caf1209
to
952abbd
Compare
Dots, | ||
Table, | ||
Prompt, | ||
Sun, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add Sparkles for system?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works with both system wide and browser-level dark / light / system toggles 👍🏼
CleanShot.2024-09-17.at.21.30.19.mp4
Something about this seems like the text in the two labels "Appearance System" seems misaligned. I think the "System" either needs to be exactly the same text size, or else a size down from current
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good me. Do we need tests for any of this?
packages/ui/core-components/src/lib/organisms/layout/EvidenceDefaultLayout.svelte
Show resolved
Hide resolved
I created |
Description
Adds support for a dark theme, and customization of light/dark themes
Does not include any work to replace hardcoded colors (e.g.
text-green-500
) with semantic color tokens (e.g.text-success
).2024-09-17.14-07-19.mov
Checklist
I have added to the VS Code extension where applicable