Skip to content

Commit

Permalink
adding strategy to deployment spec
Browse files Browse the repository at this point in the history
  • Loading branch information
evilgn0me committed Mar 19, 2024
1 parent 44ff5e8 commit cb4d7c3
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 1 deletion.
2 changes: 1 addition & 1 deletion charts/simple-ssh-bastion/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.1.7
version: 0.1.8

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
6 changes: 6 additions & 0 deletions charts/simple-ssh-bastion/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@ metadata:
{{- include "simple-ssh-bastion.labels" . | nindent 4 }}
spec:
replicas: {{ .Values.replicaCount }}
{{- if .Values.strategy }}
strategy:
{{- with .Values.strategy }}
{{- toYaml . | nindent 2 }}

This comment has been minimized.

Copy link
@vsimon

vsimon Apr 1, 2024

@evilgn0me This probably should be nindented by 4 otherwise rollingUpdate: will be at the same indentation level as strategy:.

{{- end }}
{{- end }}
selector:
matchLabels:
{{- include "simple-ssh-bastion.selectorLabels" . | nindent 6 }}
Expand Down
6 changes: 6 additions & 0 deletions charts/simple-ssh-bastion/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,12 @@ persistence:
accessMode: ReadWriteOnce
size: 1Gi

# deployment strategy, since by default we are creating persistance this should be set to 100 max unavailable.
strategy:
rollingUpdate:
maxSurge: 100%
maxUnavailable: 100%

imagePullSecrets: []
nameOverride: ""
fullnameOverride: ""
Expand Down

0 comments on commit cb4d7c3

Please sign in to comment.