Add support sqlite #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prog-supdex
force-pushed
the
ci_sqlite
branch
from
5b2b036 to
39588a0
Compare
prog-supdex
force-pushed
the
ci_sqlite
branch
from
39588a0 to
1bfd302
Compare
prog-supdex
force-pushed
the
ci_sqlite
branch
from
1898270 to
9bfeeba
Compare
palkan
requested changes
Oct 27, 2023
| @@ -2,15 +2,19 @@ | |||
|
|
|||
| module ActiveRecordSlottedCounters | |||
| module Adapters | |||
| class PgUpsert | |||
| class PgSqliteUpsert | |||
There was a problem hiding this comment.
The adapter pattern means separating implementations, not mixing them up. Please, fix this. There should not be any changes to the existing PgUpsert class.
There was a problem hiding this comment.
yeah
I just thought that SQLite adapter has the same functionality, and maybe the apply? method could resolve it
but I got it, fixed it
and in that case, the duplication is not bad, because we have two different implementations
thanks
| @@ -3,7 +3,7 @@ | |||
| module ActiveRecordSlottedCounters | |||
| module Adapters | |||
| class RailsUpsert | |||
| attr_reader :klass | |||
| attr_reader :klass, :current_adapter_name | |||
There was a problem hiding this comment.
Where do we use current_adapter_name?
There was a problem hiding this comment.
Yep, sorry, It was leaked from another branch
fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Added SQLite support
Is there anything you'd like reviewers to focus on?
SQLite supports all needed functions (ON CONFLICT, RETURNING), so we can use the same
PgUpsertAdaptercode.I added to the method
apply?checking SQLite db, tooChecklist