[WIP] Improved the collections test code #428

ccheraa · 2021-06-04T09:59:16Z

Removed unnecessary nesting, and extra Cypress calls.
Added spies for collection related api calls.

duncdrum

Something went wrong with the merging / rebasing it seems. I very much like the additions to the collections test, and will cherry-pick 47f368e into my next PR. I have a better solution to the OS specific keyboard short cuts in duncdrum@599610d instead of mashing three keys conditionally run the appropriate two key combo

ccheraa · 2021-06-14T09:03:48Z

The collections and documents specs now work individually without problems.
But if they are run alongside the other specs, sometimes, a test in one of them fails, even though the state of the db of those specs two specs is completely isolated from the other specs.

duncdrum · 2021-06-14T09:37:49Z

initial run:

"before all" hook for "should display creation options":
     CypressError: The following error originated from your test code, not from Cypress. It was caused by an unhandled promise rejection.

  > 

When Cypress detects uncaught errors originating from your test code it will automatically fail the current test.

Because this error occurred during a `before all` hook we are skipping the remaining tests in the current suite: `working with tree view`
  Error: The following error originated from your test code, not from Cypress. It was caused by an unhandled promise rejection.
  
    > 
  
  When Cypress detects uncaught errors originating from your test code it will automatically fail the current test.
  Error

duncdrum

Have you tried running these on your Linux dev server (i.e. dv) ?
I can't get them to run at all. We are now establishing connections in two different ways within the same hook, that is bound to be flaky. The ApI connection stuff, happens without a matching test assertion, which explains the error message, The docs have some example code that on point. Let's clean those hooks up a bit see #400

There are a number of places where we can reuse existing test artifacts, lets.

duncdrum · 2021-06-14T11:18:14Z

cypress/integration/05_collection_spec.js

+    })
+    after(() => {
+      // delete the test colelction
+      new Cypress.Promise(resolve => FSApi.remove(connection, '/db/test', true).then(resolve).catch(resolve))


The before and after hooks of the document spec are better, please match them here.

duncdrum · 2021-06-14T11:22:45Z

cypress/integration/05_collection_spec.js

+      // (DP): end workaround for #413
+      cy.get('[node-id$=test]')
+        .click()
+        .prev().should('not.have.class', 'fa-spin')


why are we testing spin here, multiple times ?

This here is to make sure the node is done loading
I added the wait because it turned out that the spin disappears before the rest of the tree is rendered (the nodes are not rendered all at once), so the wait is to give React enough time to update the dom

duncdrum · 2021-06-14T11:25:10Z

cypress/integration/05_collection_spec.js

-          .should('not.exist')
+    it('should move a collection', () => {
+      const dataTransfer = new DataTransfer();
+      cy.get('[node-id$="test\\/col1"]')


another good place to reuse existing test or system artifacts instead of creating our own.

We need to create dataTransfer object for two tests only, so I thought it would be overkill to create it under beforeAll, and we shouldn't create in before because it shouldn't be reused.

my point wasn't about the before hooks but about the collections which have been created from earlier test cases, lets re-use whats already been generated and tested.

duncdrum · 2021-06-14T11:26:44Z

cypress/integration/05_collection_spec.js


+    it('should not move a collection to one of its sub-collections', () => {


duplicate test case?

duncdrum · 2021-06-14T11:28:08Z

fusion-studio-extension/src/browser/core.ts

@@ -1321,7 +1321,9 @@ export class FSCore {
      node.uri = name;
    }
    node.nodeName = this.getName(name);;
+    delete(this.dict[node.nodeId]);


please link open issues related to the fix from the commit message, if there isn't an open issue already create a new one

ccheraa · 2021-06-16T22:03:50Z

This fixes #433

…ect-setup Refactor testsuite

Update dependencies

see evolvedbinary#452

Bumps [cypress](https://github.com/cypress-io/cypress) from 7.6.0 to 8.0.0. - [Release notes](https://github.com/cypress-io/cypress/releases) - [Changelog](https://github.com/cypress-io/cypress/blob/develop/.releaserc.base.js) - [Commits](cypress-io/cypress@v7.6.0...v8.0.0) --- updated-dependencies: - dependency-name: cypress dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

…m_and_yarn/cypress-8.0.0 chore(deps-dev): bump cypress from 7.6.0 to 8.0.0

Update dependencies

ccheraa · 2021-07-23T07:28:15Z

Moved to PR #459

cla-bot bot added the cla-signed label Jun 4, 2021

duncdrum self-requested a review June 4, 2021 20:36

duncdrum reviewed Jun 4, 2021

View reviewed changes

duncdrum mentioned this pull request Jun 4, 2021

End-to-end Rewrite 4 #429

Merged

ccheraa force-pushed the tests-rewrite branch 2 times, most recently from 5fac551 to 2199463 Compare June 9, 2021 14:13

ccheraa changed the title ~~Improved the collections test code~~ [WIP] Improved the collections test code Jun 14, 2021

duncdrum force-pushed the circleci-project-setup branch from fff868a to d23f90c Compare June 14, 2021 11:00

duncdrum self-requested a review June 14, 2021 11:06

duncdrum suggested changes Jun 14, 2021

View reviewed changes

adamretter and others added 17 commits June 17, 2021 09:49

Merge pull request evolvedbinary#377 from evolvedbinary/circleci-proj…

0ff5010

…ect-setup Refactor testsuite

fix: webpack no longer bundle polyfills

edd8fe0

updated theia to 1.14.0

0914ca8

update theia to 1.15.0

9a0f60e

Merge pull request evolvedbinary#448 from ccheraa/update-dependencies

8879013

Update dependencies

hotfix(ci): use chrome headless

842f41f

see evolvedbinary#452

hptfix(c): add chrome

fab2bb3

fix(ci): add chrome deps

359be59

fix(ci): adjust cypress run syntax

aa11e78

Merge pull request evolvedbinary#456 from evolvedbinary/dependabot/np…

fa8128e

…m_and_yarn/cypress-8.0.0 chore(deps-dev): bump cypress from 7.6.0 to 8.0.0

fix: electron test don't work anymore

cf330bd

use real process variable instead of a placeholder

860d083

updated packages

732575a

Merge pull request evolvedbinary#457 from ccheraa/update-dependencies

a6b656f

Update dependencies

added drag and drop test

01d98d6

move drag and drop tests to documents and collections specs

73bcf63

ccheraa added 5 commits July 23, 2021 08:20

fix: node id not updated after renaming

17230f0

added drag and drop upload tests

0a74559

split upload tests between document and collection

fd9318b

added upload dialog test

800fa00

expand a collapsed collection when creating items

e9b9576

ccheraa force-pushed the tests-rewrite branch from dd3ebb6 to e9b9576 Compare July 23, 2021 07:24

ccheraa mentioned this pull request Jul 23, 2021

[WIP] Added tests #459

Draft

ccheraa closed this Jul 23, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Improved the collections test code #428

[WIP] Improved the collections test code #428

ccheraa commented Jun 4, 2021

duncdrum left a comment •

edited

Loading

ccheraa commented Jun 14, 2021

duncdrum commented Jun 14, 2021

duncdrum left a comment •

edited by adamretter

Loading

duncdrum Jun 14, 2021

duncdrum Jun 14, 2021

ccheraa Jun 16, 2021

duncdrum Jun 14, 2021

ccheraa Jun 16, 2021

duncdrum Jul 1, 2021

duncdrum Jun 14, 2021

duncdrum Jun 14, 2021

ccheraa commented Jun 16, 2021

ccheraa commented Jul 23, 2021


		it('should not move a collection to one of its sub-collections', () => {

[WIP] Improved the collections test code #428

[WIP] Improved the collections test code #428

Conversation

ccheraa commented Jun 4, 2021

duncdrum left a comment • edited Loading

Choose a reason for hiding this comment

ccheraa commented Jun 14, 2021

duncdrum commented Jun 14, 2021

duncdrum left a comment • edited by adamretter Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ccheraa commented Jun 16, 2021

ccheraa commented Jul 23, 2021

duncdrum left a comment •

edited

Loading

duncdrum left a comment •

edited by adamretter

Loading