Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup tslint for the assemblyscript code #20

Open
s1na opened this issue Dec 4, 2019 · 3 comments
Open

Setup tslint for the assemblyscript code #20

s1na opened this issue Dec 4, 2019 · 3 comments
Labels
blocked Depends on external action ci good first issue Good for newcomers

Comments

@s1na
Copy link
Collaborator

s1na commented Dec 4, 2019

The AssemblyScript project seems to have a configuration for tslint. It's not clear how to use it though since @assemblyscript/lint is not a published package on npm.

@s1na s1na added ci good first issue Good for newcomers labels Dec 4, 2019
@hugo-dc
Copy link
Member

hugo-dc commented Dec 6, 2019

It would be good to also fix the scripts below:

  • build (used in relayer) - fails
  • tslint - some more directories need to be included (assembly/, test/, etc)

@s1na
Copy link
Collaborator Author

s1na commented Dec 6, 2019

build (used in relayer) - fails

Oh it does? I think it works for me. Can you create an issue with the error you get?

tslint - some more directories need to be included (assembly/, test/, etc)

👍

@hugo-dc
Copy link
Member

hugo-dc commented Dec 11, 2019

As you said, @AssemblyScript/lint is not yet available as an npm module, and according to this issue , currently it is used to internal development and is likely to be migrated to eslint.

@s1na s1na added the blocked Depends on external action label Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Depends on external action ci good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants