use Common to set the hardfork name correctly #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1na
reviewed
Jan 23, 2020
package.json
Outdated
| @@ -54,6 +54,7 @@ | |||
| "axios": "^0.19.0", | |||
| "bn.js": "^5.0.0", | |||
| "ethereumjs-account": "^3.0.0", | |||
| "ethereumjs-common": "^1.5.0", | |||
| "ethereumjs-testing": "git+https://github.com/ethereumjs/ethereumjs-testing.git#v1.2.7", | |||
| "ethereumjs-util": "^6.1.0", | |||
| "ethereumjs-vm": "^4.1.0", | |||
There was a problem hiding this comment.
Can you update the VM to v4.1.3? The change in getOpcodesForHF (ethereumjs/ethereumjs-monorepo#647) was introduced then.
s1na
reviewed
Jan 31, 2020
|
Sorry for the delay, I made the change you suggested, also fixed an error (chain was missing when selecting a hardfork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.