Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests to include V8 / Update to vsjdbc 12.0.0 #34

Merged
merged 4 commits into from
Mar 26, 2024
Merged

Update tests to include V8 / Update to vsjdbc 12.0.0 #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
95686c6
#25 : update Ci to include v8, major version increase because of earl…
pj-spoelders Mar 26, 2024
6eca933
fix container startup issue
pj-spoelders Mar 26, 2024
17ca12a
Update changes_3.0.0.md
pj-spoelders Mar 26, 2024
677f116
Apply suggestions from code review
pj-spoelders Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci-build.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions .project-keeper.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,6 @@ build:
runnerOs: ubuntu-20.04
exasolDbVersions:
- "7.1.25"
- "8.24.0"
freeDiskSpace: true
excludes:
1 change: 1 addition & 0 deletions doc/changes/changelog.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 15 additions & 0 deletions doc/changes/changes_3.0.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
# Virtual Schema for DB2 3.0.0, released 2024-03-26

Code name: Charset is always `utf-8`, deprecated IMPORT_DATA_TYPES `FROM_RESULT_SET` value

## Summary

The behaviour when it comes to character sets is now simplified,
The target char set is now always UTF-8.
The `IMPORT_DATA_TYPES` property (and value `FROM_RESULT_SET`) are now deprecated (change in vs-common-jdbc):
An exception will be thrown when users use`FROM_RESULT_SET`. The exception message warns the user that the value is no longer supported and the property itself is also deprecated.

## Refactoring

* #25: Updated tests to Exasol v8, updated to vsjdbc 12.0.0

4 changes: 2 additions & 2 deletions doc/user_guide/db2_user_guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ The SQL statement below creates the adapter script, defines the Java class that
```sql
CREATE OR REPLACE JAVA ADAPTER SCRIPT ADAPTER.JDBC_ADAPTER AS
%scriptclass com.exasol.adapter.RequestDispatcher;
%jar /buckets/<BFS service>/<bucket>/virtual-schema-dist-12.0.0-db2-2.1.4.jar;
%jar /buckets/<BFS service>/<bucket>/virtual-schema-dist-12.0.0-db2-3.0.0.jar;
%jar /buckets/<BFS service>/<bucket>/db2jcc4.jar;
%jar /buckets/<BFS service>/<bucket>/db2jcc_license_cu.jar;
/
Expand All @@ -68,7 +68,7 @@ CREATE OR REPLACE JAVA ADAPTER SCRIPT ADAPTER.JDBC_ADAPTER AS
```sql
CREATE OR REPLACE JAVA ADAPTER SCRIPT ADAPTER.JDBC_ADAPTER AS
%scriptclass com.exasol.adapter.RequestDispatcher;
%jar /buckets/<BFS service>/<bucket>/virtual-schema-dist-12.0.0-db2-2.1.4.jar;
%jar /buckets/<BFS service>/<bucket>/virtual-schema-dist-12.0.0-db2-3.0.0.jar;
%jar /buckets/<BFS service>/<bucket>/db2jcc4.jar;
%jar /buckets/<BFS service>/<bucket>/db2jcc_license_cu.jar;
%jar /buckets/<BFS service>/<bucket>/db2jcc_license_cisuz.jar;
Expand Down
2 changes: 1 addition & 1 deletion pk_generated_parent.pom
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<modelVersion>4.0.0</modelVersion>
<groupId>com.exasol</groupId>
<artifactId>db2-virtual-schema</artifactId>
<version>2.1.4</version>
<version>3.0.0</version>
<name>Virtual Schema for DB2</name>
<description>Virtual Schema for connecting DB2 as a data source to Exasol</description>
<url>https://github.com/exasol/db2-virtual-schema/</url>
Expand Down Expand Up @@ -183,7 +183,7 @@
<parent>
<artifactId>db2-virtual-schema-generated-parent</artifactId>
<groupId>com.exasol</groupId>
<version>2.1.4</version>
<version>3.0.0</version>
<relativePath>pk_generated_parent.pom</relativePath>
</parent>
</project>
2 changes: 1 addition & 1 deletion src/test/java/com/exasol/adapter/dialects/db2/IntegrationTestConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ public class IntegrationTestConfiguration {
public static final String EXASOL_DOCKER_REFERENCE = "7.1.19";
public static final DockerImageName DB2_DOCKER_REFERENCE = DockerImageName
.parse("icr.io/db2_community/db2:11.5.8.0").asCompatibleSubstituteFor("ibmcom/db2");
public static final String VIRTUAL_SCHEMAS_JAR_NAME_AND_VERSION = "virtual-schema-dist-12.0.0-db2-2.1.4.jar";
public static final String VIRTUAL_SCHEMAS_JAR_NAME_AND_VERSION = "virtual-schema-dist-12.0.0-db2-3.0.0.jar";
public static final Path PATH_TO_VIRTUAL_SCHEMAS_JAR = Path.of("target", VIRTUAL_SCHEMAS_JAR_NAME_AND_VERSION);
public static final int DB2_PORT = 50000;
public static final String JDBC_DRIVER_CONFIGURATION_FILE_NAME = "settings.cfg";
Expand Down