Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor parameters of luigi tasks #356

Open
ckunki opened this issue Jun 26, 2023 · 0 comments
Open

Refactor parameters of luigi tasks #356

ckunki opened this issue Jun 26, 2023 · 0 comments
Labels
refactoring Code improvement without behavior change

Comments

@ckunki
Copy link
Contributor

ckunki commented Jun 26, 2023

Currently luigi tasks are using separate parameters for port specification.

E.g. class DockerDBTestEnvironmentParameter uses 3 separate parameters

    database_port_forward = luigi.OptionalParameter(None, significant=False)
    bucketfs_port_forward = luigi.OptionalParameter(None, significant=False)
    ssh_port_forward = luigi.OptionalParameter(None, significant=False)

The current ticket proposes to combine these parameters into a single parameter of type Ports:

    port_forwards =  JsonPickleParameter(Ports, significant=False)
@ckunki ckunki added the refactoring Code improvement without behavior change label Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code improvement without behavior change
Projects
None yet
Development

No branches or pull requests

1 participant