Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpawnTestEnvironment for external database cannot be used with SSH executor #403

Open
tomuben opened this issue May 21, 2024 · 0 comments
Open
Labels
bug Unwanted / harmful behavior

Comments

@tomuben
Copy link
Collaborator

tomuben commented May 21, 2024

When using the luigi task SpawnTestEnvironment with an external database, the returned EnvironmentInfo object does not contain all necessary values to use later the SshExecFactory/SshExecutor. e.g. test_environment_info.database_info.user is missing.

Acceptance Criteria

  1. Task SpawnTestEnvironment accepts additional parameters, e.g. ssh_user, ssh_public_keyfile
  2. The task or subsequent api layers add this parameter to the instance of class lib.data.environment_info.EnvironmentInfo
  3. Create a test for this scenario
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unwanted / harmful behavior
Projects
None yet
Development

No branches or pull requests

1 participant