Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ssh key handling #431

Open
tomuben opened this issue Nov 25, 2024 · 0 comments
Open

Refactor ssh key handling #431

tomuben opened this issue Nov 25, 2024 · 0 comments
Labels
refactoring Code improvement without behavior change

Comments

@tomuben
Copy link
Collaborator

tomuben commented Nov 25, 2024

Background

In file spawn_test_database.py
ssh_key_file is re-used and overwritten several times: sometimes it gets a string assigned, sometimes a Path.

Originally posted by @tomuben in #426 (comment)

We should different variables and avoid re-assigning to the luigi parameter.

Acceptance Criteria

  1. Type of SpawnTestDockerDatabase.ssh_key_file must be str:
ssh_key_file : str = luigi.OptionalParameter(None, significant=False) # type: ignore
@redcatbear redcatbear added the refactoring Code improvement without behavior change label Dec 20, 2024
@tkilias tkilias added refactoring Code improvement without behavior change and removed refactoring Code improvement without behavior change labels Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code improvement without behavior change
Projects
None yet
Development

No branches or pull requests

3 participants