Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a smoke test #253

Open
SeanKilleen opened this issue May 6, 2020 · 0 comments
Open

Add a smoke test #253

SeanKilleen opened this issue May 6, 2020 · 0 comments

Comments

@SeanKilleen
Copy link
Contributor

SeanKilleen commented May 6, 2020

As part of #251, I realized that our tests didn't catch the issue because we don't have a smoke test in place that actually attempts to load the whole JS package (which would have caught the webpack issue with loading JS files).

We have an HTML page that we use for integration tests. I wonder how difficult it would be to load that in a browser window (real via cypress or via JSDom if possible), run the summarizer JS loader code, and then assert that the summarizer window is present?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant