Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added missing localization strings in Kit/process.swift #1903

Merged
merged 8 commits into from
Apr 21, 2024

Conversation

AhmedAbouelkher
Copy link
Contributor

@AhmedAbouelkher AhmedAbouelkher commented Apr 19, 2024

In this PR I've added missing localization strings in Kit/process.swift which was Process and Kill process. The missing keys were added to all language strings under Module Kit.

Side Note: I have minor bug fixes in mind, but I need a build guide #1881 to debug the program easily, I tried building the project multiple times but failed, I always encounter this error Include of non-modular header inside framework module 'Kit': 'stats/Kit/lldb/lldb.h'.

@AhmedAbouelkher AhmedAbouelkher marked this pull request as ready for review April 19, 2024 12:17
@exelban
Copy link
Owner

exelban commented Apr 21, 2024

hi. Thanks for contribution.
This time I will merge PR like that. But please make a PR with clean history.

@exelban exelban merged commit 495b5b3 into exelban:master Apr 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants