-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
difference-of-squares: Sync tests #696
Conversation
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.
For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
Thanks Isaac. Any idea why it still shows merging blocked? |
e3ae5c6
to
bfbffbe
Compare
@bobbicodes @michalporeba Could one of you, as track maintainers, approve? |
43b9123
to
77c2369
Compare
I think it's blocked on a maintainer approval |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please merge with [no important files changed]
(defn square-of-sum [] ;; <- arglist goes here | ||
;; your code goes here | ||
) | ||
(defn difference |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love that you moved this to the bottom
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love that you also did the same 😄
Also updated the difference_of_squares.clj starter file with a proper function template