Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isogram: Sync tests #705

Merged
merged 8 commits into from
Jan 11, 2025
Merged

isogram: Sync tests #705

merged 8 commits into from
Jan 11, 2025

Conversation

tasxatzial
Copy link
Member

@tasxatzial tasxatzial commented Nov 9, 2024

Also

  • Updated the isogram.clj starter file with a proper function template
  • Split into one deftest per test
  • Explicitly check with true? and false? as true and false are the exact values expected to be returned by isogram?
  • Written a new example solution that passes the tests. It is expected that some of the community solutions will be invalided.

Copy link
Contributor

github-actions bot commented Nov 9, 2024

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@tasxatzial tasxatzial mentioned this pull request Jan 11, 2025
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tasxatzial Please merge with [no important files changed] in the commit message

@tasxatzial tasxatzial merged commit 53bc55d into exercism:main Jan 11, 2025
2 checks passed
@tasxatzial tasxatzial deleted the isogram branch January 12, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants