-
-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build concept exercises + fix concept exercise that does not build. #915
Conversation
…ble’ to ‘int’ [-Werror=narrowing]' caused by list initialization syntax converting a double to int.
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
@vaeng can you review this? |
Thank you for your PR. My CMake-foo is not the best, I would prefer @ahans or @siebenschlaefer to look at your changes. Please do not mix different issues into one PR. It is easier to handle pull requests if they only concern one problem at a time. |
…fy'." This reverts commit 235b2ea.
@vaeng I reverted my change to the docs and created a separate PR for that: #918 Can you open that? The change in the non-compiling exercise is not really unrelated to the fix in the pipeline, in that the pipeline can only be fixed if all exercises compile. So I will keep that as is for now. If your PR completes before mine I can fix that by merging. CI is failing on Windows, I will look into that. |
I wanted to fix issue #878, but noticed that the
doctor-data
exercise was not built or tested when the track was built. It turned out that this was the case for all concept exercises. I am assuming this is NOT by design.I did the following:
freelancer-rates
that did not build.Fix a typo in the text that comes with thefreelancer-rates
exercise.freelancer-rates
failed to build because of the following line of code:Narrowing conversions (
ceil()
returns adouble
) are not allowed with list-initialization.I tested the build of the track with
cmake . && make
on Ubuntu 22.04.