diff --git a/exercises/concept/doctor-data/CMakeLists.txt b/exercises/concept/doctor-data/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/concept/doctor-data/CMakeLists.txt +++ b/exercises/concept/doctor-data/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/concept/election-day/CMakeLists.txt b/exercises/concept/election-day/CMakeLists.txt index e46606bd5..ba6b66368 100644 --- a/exercises/concept/election-day/CMakeLists.txt +++ b/exercises/concept/election-day/CMakeLists.txt @@ -58,9 +58,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/concept/ellens-alien-game/CMakeLists.txt b/exercises/concept/ellens-alien-game/CMakeLists.txt index b79c51e67..8e21222a2 100644 --- a/exercises/concept/ellens-alien-game/CMakeLists.txt +++ b/exercises/concept/ellens-alien-game/CMakeLists.txt @@ -57,9 +57,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/concept/freelancer-rates/CMakeLists.txt b/exercises/concept/freelancer-rates/CMakeLists.txt index b79c51e67..8e21222a2 100644 --- a/exercises/concept/freelancer-rates/CMakeLists.txt +++ b/exercises/concept/freelancer-rates/CMakeLists.txt @@ -57,9 +57,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/concept/interest-is-interesting/CMakeLists.txt b/exercises/concept/interest-is-interesting/CMakeLists.txt index b79c51e67..8e21222a2 100644 --- a/exercises/concept/interest-is-interesting/CMakeLists.txt +++ b/exercises/concept/interest-is-interesting/CMakeLists.txt @@ -57,9 +57,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/concept/lasagna-master/CMakeLists.txt b/exercises/concept/lasagna-master/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/concept/lasagna-master/CMakeLists.txt +++ b/exercises/concept/lasagna-master/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/concept/lasagna/CMakeLists.txt b/exercises/concept/lasagna/CMakeLists.txt index b79c51e67..8e21222a2 100644 --- a/exercises/concept/lasagna/CMakeLists.txt +++ b/exercises/concept/lasagna/CMakeLists.txt @@ -57,9 +57,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/concept/last-will/CMakeLists.txt b/exercises/concept/last-will/CMakeLists.txt index b79c51e67..8e21222a2 100644 --- a/exercises/concept/last-will/CMakeLists.txt +++ b/exercises/concept/last-will/CMakeLists.txt @@ -57,9 +57,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/concept/log-levels/CMakeLists.txt b/exercises/concept/log-levels/CMakeLists.txt index 621e22b9e..44ef334b3 100644 --- a/exercises/concept/log-levels/CMakeLists.txt +++ b/exercises/concept/log-levels/CMakeLists.txt @@ -57,9 +57,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/concept/making-the-grade/CMakeLists.txt b/exercises/concept/making-the-grade/CMakeLists.txt index e46606bd5..ba6b66368 100644 --- a/exercises/concept/making-the-grade/CMakeLists.txt +++ b/exercises/concept/making-the-grade/CMakeLists.txt @@ -58,9 +58,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/concept/pacman-rules/CMakeLists.txt b/exercises/concept/pacman-rules/CMakeLists.txt index b79c51e67..8e21222a2 100644 --- a/exercises/concept/pacman-rules/CMakeLists.txt +++ b/exercises/concept/pacman-rules/CMakeLists.txt @@ -57,9 +57,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/concept/troll-the-trolls/CMakeLists.txt b/exercises/concept/troll-the-trolls/CMakeLists.txt index b79c51e67..8e21222a2 100644 --- a/exercises/concept/troll-the-trolls/CMakeLists.txt +++ b/exercises/concept/troll-the-trolls/CMakeLists.txt @@ -57,9 +57,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/concept/vehicle-purchase/CMakeLists.txt b/exercises/concept/vehicle-purchase/CMakeLists.txt index 2beb1d2b4..24d8a62a6 100644 --- a/exercises/concept/vehicle-purchase/CMakeLists.txt +++ b/exercises/concept/vehicle-purchase/CMakeLists.txt @@ -60,9 +60,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/acronym/CMakeLists.txt b/exercises/practice/acronym/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/acronym/CMakeLists.txt +++ b/exercises/practice/acronym/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/all-your-base/CMakeLists.txt b/exercises/practice/all-your-base/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/all-your-base/CMakeLists.txt +++ b/exercises/practice/all-your-base/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/allergies/CMakeLists.txt b/exercises/practice/allergies/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/allergies/CMakeLists.txt +++ b/exercises/practice/allergies/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/anagram/CMakeLists.txt b/exercises/practice/anagram/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/anagram/CMakeLists.txt +++ b/exercises/practice/anagram/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/armstrong-numbers/CMakeLists.txt b/exercises/practice/armstrong-numbers/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/armstrong-numbers/CMakeLists.txt +++ b/exercises/practice/armstrong-numbers/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/atbash-cipher/CMakeLists.txt b/exercises/practice/atbash-cipher/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/atbash-cipher/CMakeLists.txt +++ b/exercises/practice/atbash-cipher/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/bank-account/CMakeLists.txt b/exercises/practice/bank-account/CMakeLists.txt index 35dff48c4..82efa96b9 100644 --- a/exercises/practice/bank-account/CMakeLists.txt +++ b/exercises/practice/bank-account/CMakeLists.txt @@ -59,9 +59,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/beer-song/CMakeLists.txt b/exercises/practice/beer-song/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/beer-song/CMakeLists.txt +++ b/exercises/practice/beer-song/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/binary-search-tree/CMakeLists.txt b/exercises/practice/binary-search-tree/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/binary-search-tree/CMakeLists.txt +++ b/exercises/practice/binary-search-tree/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/binary-search/CMakeLists.txt b/exercises/practice/binary-search/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/binary-search/CMakeLists.txt +++ b/exercises/practice/binary-search/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/binary/CMakeLists.txt b/exercises/practice/binary/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/binary/CMakeLists.txt +++ b/exercises/practice/binary/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/bob/CMakeLists.txt b/exercises/practice/bob/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/bob/CMakeLists.txt +++ b/exercises/practice/bob/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/circular-buffer/CMakeLists.txt b/exercises/practice/circular-buffer/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/circular-buffer/CMakeLists.txt +++ b/exercises/practice/circular-buffer/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/clock/CMakeLists.txt b/exercises/practice/clock/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/clock/CMakeLists.txt +++ b/exercises/practice/clock/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/collatz-conjecture/CMakeLists.txt b/exercises/practice/collatz-conjecture/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/collatz-conjecture/CMakeLists.txt +++ b/exercises/practice/collatz-conjecture/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/complex-numbers/CMakeLists.txt b/exercises/practice/complex-numbers/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/complex-numbers/CMakeLists.txt +++ b/exercises/practice/complex-numbers/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/crypto-square/CMakeLists.txt b/exercises/practice/crypto-square/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/crypto-square/CMakeLists.txt +++ b/exercises/practice/crypto-square/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/darts/CMakeLists.txt b/exercises/practice/darts/CMakeLists.txt index 6069efae3..dba98a931 100644 --- a/exercises/practice/darts/CMakeLists.txt +++ b/exercises/practice/darts/CMakeLists.txt @@ -55,10 +55,13 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build -add_custom_target(test_${exercise} ALL DEPENDS ${exercise} COMMAND ${exercise}) \ No newline at end of file +add_custom_target(test_${exercise} ALL DEPENDS ${exercise} COMMAND ${exercise}) diff --git a/exercises/practice/darts/darts_test.cpp b/exercises/practice/darts/darts_test.cpp index 83ffa1be2..ccba524b9 100644 --- a/exercises/practice/darts/darts_test.cpp +++ b/exercises/practice/darts/darts_test.cpp @@ -34,41 +34,41 @@ TEST_CASE("exactly_on_centre") TEST_CASE("near_the_centre") { - REQUIRE(darts::score(-0.1,-0.1) == 10); + REQUIRE(darts::score(-0.1f,-0.1f) == 10); } TEST_CASE("just_within_the_inner_circle") { - REQUIRE(darts::score(0.7,0.7) == 10); + REQUIRE(darts::score(0.7f,0.7f) == 10); } TEST_CASE("just_outside_the_inner_circle") { - REQUIRE(darts::score(0.8,-0.8) == 5); + REQUIRE(darts::score(0.8f,-0.8f) == 5); } TEST_CASE("just_within_the_middle_circle") { - REQUIRE(darts::score(-3.5,3.5) == 5); + REQUIRE(darts::score(-3.5f,3.5f) == 5); } TEST_CASE("just_outside_the_middle_circle") { - REQUIRE(darts::score(-3.6,-3.6) == 1); + REQUIRE(darts::score(-3.6f,-3.6f) == 1); } TEST_CASE("just_within_the_outer_circle") { - REQUIRE(darts::score(-7.0,7.0) == 1); + REQUIRE(darts::score(-7.0f,7.0f) == 1); } TEST_CASE("just_outside_the_outer_circle") { - REQUIRE(darts::score(7.1,-7.1) == 0); + REQUIRE(darts::score(7.1f,-7.1f) == 0); } TEST_CASE("asymmetric_position_between_the_inner_and_middle_circles") { - REQUIRE(darts::score(0.5,-4) == 5); + REQUIRE(darts::score(0.5f,-4) == 5); } #endif diff --git a/exercises/practice/diamond/CMakeLists.txt b/exercises/practice/diamond/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/diamond/CMakeLists.txt +++ b/exercises/practice/diamond/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/difference-of-squares/CMakeLists.txt b/exercises/practice/difference-of-squares/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/difference-of-squares/CMakeLists.txt +++ b/exercises/practice/difference-of-squares/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/dnd-character/CMakeLists.txt b/exercises/practice/dnd-character/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/dnd-character/CMakeLists.txt +++ b/exercises/practice/dnd-character/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/eliuds-eggs/CMakeLists.txt b/exercises/practice/eliuds-eggs/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/eliuds-eggs/CMakeLists.txt +++ b/exercises/practice/eliuds-eggs/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/etl/CMakeLists.txt b/exercises/practice/etl/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/etl/CMakeLists.txt +++ b/exercises/practice/etl/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/food-chain/CMakeLists.txt b/exercises/practice/food-chain/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/food-chain/CMakeLists.txt +++ b/exercises/practice/food-chain/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/gigasecond/CMakeLists.txt b/exercises/practice/gigasecond/CMakeLists.txt index e0b1e6b11..9ee7f8a43 100644 --- a/exercises/practice/gigasecond/CMakeLists.txt +++ b/exercises/practice/gigasecond/CMakeLists.txt @@ -66,9 +66,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/grade-school/CMakeLists.txt b/exercises/practice/grade-school/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/grade-school/CMakeLists.txt +++ b/exercises/practice/grade-school/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/grains/CMakeLists.txt b/exercises/practice/grains/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/grains/CMakeLists.txt +++ b/exercises/practice/grains/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/hamming/CMakeLists.txt b/exercises/practice/hamming/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/hamming/CMakeLists.txt +++ b/exercises/practice/hamming/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/hello-world/CMakeLists.txt b/exercises/practice/hello-world/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/hello-world/CMakeLists.txt +++ b/exercises/practice/hello-world/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/hexadecimal/CMakeLists.txt b/exercises/practice/hexadecimal/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/hexadecimal/CMakeLists.txt +++ b/exercises/practice/hexadecimal/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/high-scores/CMakeLists.txt b/exercises/practice/high-scores/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/high-scores/CMakeLists.txt +++ b/exercises/practice/high-scores/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/isbn-verifier/CMakeLists.txt b/exercises/practice/isbn-verifier/CMakeLists.txt index 6069efae3..dba98a931 100644 --- a/exercises/practice/isbn-verifier/CMakeLists.txt +++ b/exercises/practice/isbn-verifier/CMakeLists.txt @@ -55,10 +55,13 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build -add_custom_target(test_${exercise} ALL DEPENDS ${exercise} COMMAND ${exercise}) \ No newline at end of file +add_custom_target(test_${exercise} ALL DEPENDS ${exercise} COMMAND ${exercise}) diff --git a/exercises/practice/isogram/CMakeLists.txt b/exercises/practice/isogram/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/isogram/CMakeLists.txt +++ b/exercises/practice/isogram/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/kindergarten-garden/CMakeLists.txt b/exercises/practice/kindergarten-garden/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/kindergarten-garden/CMakeLists.txt +++ b/exercises/practice/kindergarten-garden/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/knapsack/CMakeLists.txt b/exercises/practice/knapsack/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/knapsack/CMakeLists.txt +++ b/exercises/practice/knapsack/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/largest-series-product/CMakeLists.txt b/exercises/practice/largest-series-product/CMakeLists.txt index 6069efae3..dba98a931 100644 --- a/exercises/practice/largest-series-product/CMakeLists.txt +++ b/exercises/practice/largest-series-product/CMakeLists.txt @@ -55,10 +55,13 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build -add_custom_target(test_${exercise} ALL DEPENDS ${exercise} COMMAND ${exercise}) \ No newline at end of file +add_custom_target(test_${exercise} ALL DEPENDS ${exercise} COMMAND ${exercise}) diff --git a/exercises/practice/leap/CMakeLists.txt b/exercises/practice/leap/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/leap/CMakeLists.txt +++ b/exercises/practice/leap/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/linked-list/CMakeLists.txt b/exercises/practice/linked-list/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/linked-list/CMakeLists.txt +++ b/exercises/practice/linked-list/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/list-ops/CMakeLists.txt b/exercises/practice/list-ops/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/list-ops/CMakeLists.txt +++ b/exercises/practice/list-ops/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/luhn/CMakeLists.txt b/exercises/practice/luhn/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/luhn/CMakeLists.txt +++ b/exercises/practice/luhn/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/matching-brackets/CMakeLists.txt b/exercises/practice/matching-brackets/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/matching-brackets/CMakeLists.txt +++ b/exercises/practice/matching-brackets/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/meetup/CMakeLists.txt b/exercises/practice/meetup/CMakeLists.txt index e0b1e6b11..9ee7f8a43 100644 --- a/exercises/practice/meetup/CMakeLists.txt +++ b/exercises/practice/meetup/CMakeLists.txt @@ -66,9 +66,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/minesweeper/CMakeLists.txt b/exercises/practice/minesweeper/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/minesweeper/CMakeLists.txt +++ b/exercises/practice/minesweeper/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/nth-prime/CMakeLists.txt b/exercises/practice/nth-prime/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/nth-prime/CMakeLists.txt +++ b/exercises/practice/nth-prime/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/nucleotide-count/CMakeLists.txt b/exercises/practice/nucleotide-count/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/nucleotide-count/CMakeLists.txt +++ b/exercises/practice/nucleotide-count/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/pangram/CMakeLists.txt b/exercises/practice/pangram/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/pangram/CMakeLists.txt +++ b/exercises/practice/pangram/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/parallel-letter-frequency/CMakeLists.txt b/exercises/practice/parallel-letter-frequency/CMakeLists.txt index cf85aec1b..2c1edb224 100644 --- a/exercises/practice/parallel-letter-frequency/CMakeLists.txt +++ b/exercises/practice/parallel-letter-frequency/CMakeLists.txt @@ -63,9 +63,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/pascals-triangle/CMakeLists.txt b/exercises/practice/pascals-triangle/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/pascals-triangle/CMakeLists.txt +++ b/exercises/practice/pascals-triangle/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/perfect-numbers/CMakeLists.txt b/exercises/practice/perfect-numbers/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/perfect-numbers/CMakeLists.txt +++ b/exercises/practice/perfect-numbers/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/phone-number/CMakeLists.txt b/exercises/practice/phone-number/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/phone-number/CMakeLists.txt +++ b/exercises/practice/phone-number/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/pig-latin/CMakeLists.txt b/exercises/practice/pig-latin/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/pig-latin/CMakeLists.txt +++ b/exercises/practice/pig-latin/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/prime-factors/CMakeLists.txt b/exercises/practice/prime-factors/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/prime-factors/CMakeLists.txt +++ b/exercises/practice/prime-factors/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/protein-translation/CMakeLists.txt b/exercises/practice/protein-translation/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/protein-translation/CMakeLists.txt +++ b/exercises/practice/protein-translation/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/queen-attack/CMakeLists.txt b/exercises/practice/queen-attack/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/queen-attack/CMakeLists.txt +++ b/exercises/practice/queen-attack/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/rail-fence-cipher/CMakeLists.txt b/exercises/practice/rail-fence-cipher/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/rail-fence-cipher/CMakeLists.txt +++ b/exercises/practice/rail-fence-cipher/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/raindrops/CMakeLists.txt b/exercises/practice/raindrops/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/raindrops/CMakeLists.txt +++ b/exercises/practice/raindrops/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/resistor-color-duo/CMakeLists.txt b/exercises/practice/resistor-color-duo/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/resistor-color-duo/CMakeLists.txt +++ b/exercises/practice/resistor-color-duo/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/resistor-color/CMakeLists.txt b/exercises/practice/resistor-color/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/resistor-color/CMakeLists.txt +++ b/exercises/practice/resistor-color/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/reverse-string/CMakeLists.txt b/exercises/practice/reverse-string/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/reverse-string/CMakeLists.txt +++ b/exercises/practice/reverse-string/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/rna-transcription/CMakeLists.txt b/exercises/practice/rna-transcription/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/rna-transcription/CMakeLists.txt +++ b/exercises/practice/rna-transcription/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/robot-name/CMakeLists.txt b/exercises/practice/robot-name/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/robot-name/CMakeLists.txt +++ b/exercises/practice/robot-name/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/robot-simulator/CMakeLists.txt b/exercises/practice/robot-simulator/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/robot-simulator/CMakeLists.txt +++ b/exercises/practice/robot-simulator/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/roman-numerals/CMakeLists.txt b/exercises/practice/roman-numerals/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/roman-numerals/CMakeLists.txt +++ b/exercises/practice/roman-numerals/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/rotational-cipher/CMakeLists.txt b/exercises/practice/rotational-cipher/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/rotational-cipher/CMakeLists.txt +++ b/exercises/practice/rotational-cipher/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/run-length-encoding/CMakeLists.txt b/exercises/practice/run-length-encoding/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/run-length-encoding/CMakeLists.txt +++ b/exercises/practice/run-length-encoding/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/say/CMakeLists.txt b/exercises/practice/say/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/say/CMakeLists.txt +++ b/exercises/practice/say/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/scrabble-score/CMakeLists.txt b/exercises/practice/scrabble-score/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/scrabble-score/CMakeLists.txt +++ b/exercises/practice/scrabble-score/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/secret-handshake/CMakeLists.txt b/exercises/practice/secret-handshake/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/secret-handshake/CMakeLists.txt +++ b/exercises/practice/secret-handshake/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/series/CMakeLists.txt b/exercises/practice/series/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/series/CMakeLists.txt +++ b/exercises/practice/series/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/sieve/CMakeLists.txt b/exercises/practice/sieve/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/sieve/CMakeLists.txt +++ b/exercises/practice/sieve/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/simple-linked-list/CMakeLists.txt b/exercises/practice/simple-linked-list/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/simple-linked-list/CMakeLists.txt +++ b/exercises/practice/simple-linked-list/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/space-age/CMakeLists.txt b/exercises/practice/space-age/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/space-age/CMakeLists.txt +++ b/exercises/practice/space-age/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/spiral-matrix/CMakeLists.txt b/exercises/practice/spiral-matrix/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/spiral-matrix/CMakeLists.txt +++ b/exercises/practice/spiral-matrix/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/sublist/CMakeLists.txt b/exercises/practice/sublist/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/sublist/CMakeLists.txt +++ b/exercises/practice/sublist/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/sum-of-multiples/CMakeLists.txt b/exercises/practice/sum-of-multiples/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/sum-of-multiples/CMakeLists.txt +++ b/exercises/practice/sum-of-multiples/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/triangle/CMakeLists.txt b/exercises/practice/triangle/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/triangle/CMakeLists.txt +++ b/exercises/practice/triangle/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/trinary/CMakeLists.txt b/exercises/practice/trinary/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/trinary/CMakeLists.txt +++ b/exercises/practice/trinary/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/two-bucket/CMakeLists.txt b/exercises/practice/two-bucket/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/two-bucket/CMakeLists.txt +++ b/exercises/practice/two-bucket/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/two-fer/CMakeLists.txt b/exercises/practice/two-fer/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/two-fer/CMakeLists.txt +++ b/exercises/practice/two-fer/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/word-count/CMakeLists.txt b/exercises/practice/word-count/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/word-count/CMakeLists.txt +++ b/exercises/practice/word-count/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/yacht/CMakeLists.txt b/exercises/practice/yacht/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/yacht/CMakeLists.txt +++ b/exercises/practice/yacht/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build diff --git a/exercises/practice/zebra-puzzle/CMakeLists.txt b/exercises/practice/zebra-puzzle/CMakeLists.txt index 3b0589fd0..dba98a931 100644 --- a/exercises/practice/zebra-puzzle/CMakeLists.txt +++ b/exercises/practice/zebra-puzzle/CMakeLists.txt @@ -55,9 +55,12 @@ if(${EXERCISM_RUN_ALL_TESTS}) endif() # Tell MSVC not to warn us about unchecked iterators in debug builds +# Treat warnings as errors +# Treat type conversion warnings C4244 and C4267 as level 4 warnings, i.e. ignore them in level 3 if(${MSVC}) set_target_properties(${exercise} PROPERTIES - COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS) + COMPILE_DEFINITIONS_DEBUG _SCL_SECURE_NO_WARNINGS + COMPILE_FLAGS "/WX /w44244 /w44267") endif() # Run the tests on every build