Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve tampering test on exercise "Authentication System" #2193

Merged

Conversation

salvatore-piccione
Copy link
Contributor

@salvatore-piccione salvatore-piccione commented Oct 18, 2023

Tests for Authentication System exercises 4 and 5 can be improved by trying to actually tamper the data to ensure that the expected changes have been done. This PR adds two test cases:

  • the former is about the tampering check on the admin
  • the latter is about the tampering of developers by replacing an element in the dictionary

Exemplar solution has been updated to be more inline with the exercise request (i.e. getDevelopers() returns an instance of the interface IDictionary despite of an instance of ReadOnlyDictionary).

@github-actions
Copy link
Contributor

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Oct 18, 2023
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.0 to 4.1.1.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@8ade135...b4ffde6)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@salvatore-piccione
Copy link
Contributor Author

Hello @ErikSchierboom, I saw that checks on Configlet failed. AFAIK this is not due by the changes on this PR since the failure affects other exercises.

@salvatore-piccione salvatore-piccione force-pushed the salvatore-piccione-patch-1 branch from f9987cb to 04151e3 Compare October 19, 2023 09:21
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ErikSchierboom ErikSchierboom merged commit eff3003 into exercism:main Oct 19, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants