Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated DiamondTests.cs #2344

Closed
wants to merge 1 commit into from
Closed

Updated DiamondTests.cs #2344

wants to merge 1 commit into from

Conversation

spirit11
Copy link
Contributor

@spirit11 spirit11 commented Dec 5, 2024

Rows method adjusted to use system dependent new line characters.

Using '\n' instead of Environment.NewLine caused an issue, when all strings except the last one contain '\r' extra character, which leads to property tests failure.

`Rows` method adjusted to use system dependent new line characters.
Copy link
Contributor

github-actions bot commented Dec 5, 2024

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Dec 5, 2024
@kotp
Copy link
Member

kotp commented Dec 5, 2024

spirit11

This comment was marked as duplicate.

spirit11

This comment was marked as duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants