Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change linked-lists tests and example to use mutation. #248

Merged
merged 2 commits into from
Dec 15, 2016

Conversation

theprash
Copy link
Contributor

For #240.

I also fixed an error in pop and shift where next/prev elements weren't being set to None and the list was keeping references to items that had been removed. The tests do not check for this.

@ErikSchierboom
Copy link
Member

This looks great! Thanks.

I have one small request: could you add a HINTS.md file to the exercise's directory? In this file we should link to a page that helps users understand how to use classes in F#. I think this page would be a great resource to include. You can see an example of how such an HINTS.md file looks like here.

@theprash
Copy link
Contributor Author

theprash commented Dec 15, 2016

Why classes? The example implementation still just uses records with mutable fields. I was thinking about explaining the mutable keyword and linking to a resource.

@theprash
Copy link
Contributor Author

I've added hints mentioning both records and classes.

@ErikSchierboom ErikSchierboom merged commit d28b5f8 into exercism:master Dec 15, 2016
@ErikSchierboom
Copy link
Member

Oh sorry, I should have of course mentioned records too. I think the hints file is perfect. Merged!

Thanks a lot for all the work! 🎉

@robkeim
Copy link
Contributor

robkeim commented Dec 15, 2016

Nice job @theprash these changes look good!

@theprash theprash deleted the linked-list-mutation branch December 16, 2016 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants