Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix Issue54]: Trouble parsing unassigned expressions #55

Merged
merged 5 commits into from
Mar 27, 2024

Conversation

BethanyG
Copy link
Member

@BethanyG BethanyG commented Mar 21, 2024

fixes Issue #54 (we hope)

As a result of this fix, solutions are now being parsed better, and the placeholder assignment has improved.
The following golden tests needed to be updated:

  • [example-generator-normalization]
  • [plane-tickets]
  • [linked-list]
  • [nth-prime]
  • [palindrome-products]
  • [perfect-numbers]
  • [pov]
  • [pythagorean-triplet]

The following golden test was added to prevent this issue from regressing:

  • [example_expression_normalization]

@BethanyG
Copy link
Member Author

Additional Note: Since this code affects mostly hanging unassigned expressions and yield statements, there is probably no need to re-run all solutions. Instead, if there are issues with specific solutions, they can be re-run as needed.

@BethanyG BethanyG merged commit ff71565 into exercism:main Mar 27, 2024
2 checks passed
@BethanyG BethanyG deleted the fix-issue54 branch March 27, 2024 21:06
@BethanyG BethanyG restored the fix-issue54 branch April 23, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants