[Unpacking & Multiple Assignment/Locomotive Engineer]: Added Some Notes on Using * On the Left-Hand Side
#3826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ErikSchierboom -- ok to merge? |
|
I think this does a nice job of, first, pointing out the trailing comma for the user, and second, pointing the user to more information if needed. tyvm, @BethanyG. |
Looks good, but why are you asking me? :D |
|
Apologies @ErikSchierboom ! I should have been clearer in my note. This was one of three PRs that tested your bot fix. Rather than just doing test PRs, this one and PR 3825 are "live" changes. PR 3827 is test-only. Just wondering when to merge/close and revert PR 3824. |
|
@BethanyG I think the behavior is correct here! Thanks for the test! As for the actual merging, feel free to do whatever you like :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forum Discussion.
Didn't add a whole lot here, but I hope it helps without confusing things.