Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix time parsing in gigasecond tests #234

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Conversation

kahgoh
Copy link
Member

@kahgoh kahgoh commented Oct 24, 2024

As mentioned in #232, this is to fix the Gigasecond tests (failed in test run https://github.com/exercism/vlang/actions/runs/11506925109).

This fixes the parsing of the date strings in the tests. According to the docs the, a couple of the dates are in ISO 8601 format rather than RFC 3339. RFC 3339 requires the time zone to be specified when the String contains a time. ISO 8601 doesn't have this requirment.

See:

When merging, I think it should be marked [no important files changed] as this commit shouldn't change any past test results.

Copy link

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@kahgoh
Copy link
Member Author

kahgoh commented Oct 25, 2024

Btw, the break in the Gigasecond test seems to have been caused by this commit in Vlang: vlang/v@c55a75f

@kahgoh kahgoh force-pushed the fix/gigasecond branch 3 times, most recently from ae5676d to 3b112ec Compare October 25, 2024 00:42
This fixes the parsing of the date strings in the tests. According to the docs
the, a couple of the dates are in ISO 8601 format rather than RFC 3339.
RFC 3339 requires the time zone to be specified when the String contains a time.
ISO 8601 doesn't have this requirment.

See:
- https://modules.vlang.io/time.html#parse_rfc3339
- https://ijmacd.github.io/rfc3339-iso8601/
@kahgoh kahgoh merged commit d763455 into exercism:main Oct 25, 2024
4 checks passed
@kahgoh kahgoh deleted the fix/gigasecond branch October 25, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants