Merge pull request #42 from experius/feature/DOBO-786

[FEATURE][DOBO-786] Make sure that only image filetypes are processed…
experius · Jul 3, 2024 · 7088590 · 7088590
2 parents d85d5ea + f66460a
commit 7088590
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 3 deletions.
diff --git a/Helper/Settings.php b/Helper/Settings.php
@@ -88,6 +88,27 @@ public function getConfigValue($path)
         );
     }
 
+
+    /**
+     * This is used for the Gd2
+     *
+     * @return array
+     */
+    public function getImageFiletypes()
+    {
+        return [
+            'jpg',
+            'jpeg',
+            'png',
+            'gif',
+            'webp',
+            'bmp',
+            'xpm',
+            'xbm',
+            'wbmp'
+        ];
+    }
+
     /**
      * Get extra file types (allowed)
      *

diff --git a/Image/Adapter/Gd2.php b/Image/Adapter/Gd2.php
@@ -31,7 +31,6 @@ public function __construct(
         array $data = []
     ) {
         $this->settings = $helperSettings;
-
         parent::__construct($filesystem, $logger, $data);
     }
 
@@ -46,7 +45,7 @@ public function open($filename)
     {
         $pathInfo = pathinfo($filename);
         if (key_exists('extension', $pathInfo)
-            && in_array($pathInfo['extension'], $this->settings->getExtraFiletypes())
+            && in_array($pathInfo['extension'], $this->settings->getImageFiletypes())
         ) {
             parent::open($filename);
         }
@@ -66,7 +65,7 @@ public function save($destination = null, $newName = null)
         $fileName = $this->_prepareDestination($destination, $newName);
         $pathInfo = pathinfo($fileName);
         if (key_exists('extension', $pathInfo)
-            && in_array($pathInfo['extension'], $this->settings->getExtraFiletypes())
+            && in_array($pathInfo['extension'], $this->settings->getImageFiletypes())
         ) {
             parent::save($destination, $newName);
         }