feat: Add global mutation trigger field to EntityCompanionProvider #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josh-McFarlin
force-pushed
the
global-mutation-triggers
branch
from
371683c
to
c94ab19
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #215 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 69 70 +1
Lines 1899 1921 +22
Branches 262 267 +5
=========================================
+ Hits 1899 1921 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Josh-McFarlin
force-pushed
the
global-mutation-triggers
branch
from
f2c48bf
to
d6b7921
Compare
wschurman
requested changes
Jun 5, 2024
Josh-McFarlin
force-pushed
the
global-mutation-triggers
branch
from
f00f3e9
to
70f44f8
Compare
wschurman
changed the title
wschurman
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
Just a few changes before commit, otherwise looks good.
One other thing is I renamed the PR to use conventional commits style, so when you merge it ensure it keeps the new style in the final commit title. This just makes it so that the changelog is auto-generated.
packages/entity/src/utils/__tests__/mergeMutationTriggers-test.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Adding global mutation triggers to
EntityCompanionProviderallows the creation of mutation triggers that run for every entity.How
I added the property
globalMutationTriggerstoEntityCompanionProvider. In theEntityMutatorconstructor, themutationTriggersproperty is set to the combination ofcompanionProvider.globalMutationTriggersand any mutation triggers included in the constructor's parameter. Global mutation triggers will always run before any mutation triggers defined for the individual entity.Test Plan
I modified
EntityMutator-test.tsto include theglobalMutationTriggersduringcreateEntityMutatorFactory, and these global triggers have their trigger count verified later.