wip

expo · Sep 14, 2023 · 6b26b6b · 6b26b6b
1 parent 6c09a34
commit 6b26b6b
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 16 deletions.
diff --git a/build/preview-build/index.js b/build/preview-build/index.js
@@ -76436,8 +76436,8 @@ function getVariables(config, builds) {
         iosAppVersion: ios?.appVersion || '',
     };
 }
-function createDetails({ summary, details }) {
-    return `<details><summary>${summary}</summary>\n\n${details}\n</details>`;
+function createDetails({ summary, details, delim = '\n', }) {
+    return `<details><summary>${summary}</summary>${delim.repeat(2)}${details}${delim}</details>`;
 }
 function createMessageBodyInBuilding(builds, fingerprintDiff, input) {
     const tableRows = [];
@@ -76450,17 +76450,18 @@ function createMessageBodyInBuilding(builds, fingerprintDiff, input) {
             name = `${appPlatformEmojis.IOS} iOS build`;
         }
         else {
-            name = 'Unknown';
+            name = 'Unknown build';
         }
         const buildPageURL = getBuildLogsUrl(build);
         const details = createDetails({
             summary: 'Build Details',
             details: [
-                `- **Distribution**: \`${build.distribution}\``,
-                `- **Build profile**: \`${build.buildProfile}\``,
-                `- **SDK version**: \`${build.sdkVersion}\``,
-                `- **App version**: \`${build.appVersion}\``,
-            ].join('\n'),
+                `Distribution: \`${build.distribution}\``,
+                `Build profile: \`${build.buildProfile}\``,
+                `SDK version: \`${build.sdkVersion}\``,
+                `App version: \`${build.appVersion}\``,
+            ].join('<br>'),
+            delim: '',
         });
         tableRows.push(`| ${name} | [View build page](${buildPageURL}) | ${details} |`);
     }

diff --git a/src/actions/preview-build.ts b/src/actions/preview-build.ts
@@ -197,8 +197,16 @@ export function getVariables(config: ExpoConfig, builds: BuildInfo[]) {
   };
 }
 
-function createDetails({ summary, details }: { summary: string; details: string }): string {
-  return `<details><summary>${summary}</summary>\n\n${details}\n</details>`;
+function createDetails({
+  summary,
+  details,
+  delim = '\n',
+}: {
+  summary: string;
+  details: string;
+  delim?: string;
+}): string {
+  return `<details><summary>${summary}</summary>${delim.repeat(2)}${details}${delim}</details>`;
 }
 
 function createMessageBodyInBuilding(
@@ -214,18 +222,19 @@ function createMessageBodyInBuilding(
     } else if (build.platform === 'IOS') {
       name = `${appPlatformEmojis.IOS} iOS build`;
     } else {
-      name = 'Unknown';
+      name = 'Unknown build';
     }
 
     const buildPageURL = getBuildLogsUrl(build);
     const details = createDetails({
       summary: 'Build Details',
       details: [
-        `- **Distribution**: \`${build.distribution}\``,
-        `- **Build profile**: \`${build.buildProfile}\``,
-        `- **SDK version**: \`${build.sdkVersion}\``,
-        `- **App version**: \`${build.appVersion}\``,
-      ].join('\n'),
+        `Distribution: \`${build.distribution}\``,
+        `Build profile: \`${build.buildProfile}\``,
+        `SDK version: \`${build.sdkVersion}\``,
+        `App version: \`${build.appVersion}\``,
+      ].join('<br>'),
+      delim: '',
     });
 
     tableRows.push(`| ${name} | [View build page](${buildPageURL}) | ${details} |`);