fix suggestions + update readme

expo · Sep 24, 2024 · 9a10875 · 9a10875
1 parent 8770445
commit 9a10875
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 11 deletions.
diff --git a/continuous-deploy-fingerprint/README.md b/continuous-deploy-fingerprint/README.md
@@ -49,12 +49,13 @@
 This action is customizable through variables defined in the [`action.yml`](action.yml).
 Here is a summary of all the input options you can use.
 
-| variable                           | default          | description                                                             |
-| ---------------------------------- | ---------------- | ----------------------------------------------------------------------- |
-| **profile**                        | (required)       | The EAS Build profile to use |
-| **branch**                     | (required)       | The EAS Update branch on which to publish |
-| **working-directory**              | -                | The relative directory of your Expo app                                 |
-| **github-token**                   | `github.token`   | GitHub token to use when commenting on PR ([read more](#github-tokens)) |
+| variable              | default        | description                                                                  |
+| --------------------- | -------------- | ---------------------------------------------------------------------------- |
+| **profile**           | (required)     | The EAS Build profile to use                                                 |
+| **branch**            | (required)     | The EAS Update branch on which to publish                                    |
+| **working-directory** | -              | The relative directory of your Expo app                                      |
+| **platform**          | `all`          | The platform to deploy on (available options are `ios`, `android` and `all`) |
+| **github-token**      | `github.token` | GitHub token to use when commenting on PR ([read more](#github-tokens))      |
 
 And the action will generate these [outputs](#available-outputs) for other actions to do something based on what this action did.
 

diff --git a/src/actions/continuous-deploy-fingerprint.ts b/src/actions/continuous-deploy-fingerprint.ts
@@ -134,7 +134,7 @@ export async function continuousDeployFingerprintAction(input = collectContinuou
       config,
       projectId,
       updates,
-      builds: [android?.buildInfo, ios?.buildInfo].filter(e => e !== null) as BuildInfo[],
+      builds: [androidResult?.buildInfo, iosResult?.buildInfo].filter(e => e !== null) as BuildInfo[],
       options: input,
     });
 
@@ -146,10 +146,10 @@ export async function continuousDeployFingerprintAction(input = collectContinuou
     });
   }
 
-  setOutput('android-fingerprint', android?.fingerprint);
-  setOutput('ios-fingerprint', ios?.fingerprint);
-  setOutput('android-build-id', android?.buildInfo.id);
-  setOutput('ios-build-id', ios?.buildInfo.id);
+  setOutput('android-fingerprint', androidResult?.fingerprint);
+  setOutput('ios-fingerprint', iosResult?.fingerprint);
+  setOutput('android-build-id', androidResult?.buildInfo.id);
+  setOutput('ios-build-id', iosResult?.buildInfo.id);
   setOutput('update-output', updates);
 }