Skip to content

Commit

Permalink
[chore] Update lint and config to be more consistent with other expo …
Browse files Browse the repository at this point in the history
…codebases
  • Loading branch information
wschurman committed Sep 19, 2024
1 parent 28c4b0a commit ba9ed07
Show file tree
Hide file tree
Showing 39 changed files with 448 additions and 161 deletions.
28 changes: 28 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
module.exports = {
root: true,
extends: ['universe/node'],
ignorePatterns: ['build/**', 'node_modules/**'],
rules: {
'prettier/prettier': 'error',
'sort-imports': [
'warn',
{
ignoreDeclarationSort: true,
},
],
curly: 'warn',
},
overrides: [
{
files: ['*.ts', '*.tsx', '*.d.ts'],
extends: ['universe/shared/typescript-analysis'],
excludedFiles: ['**/tests/**'],
parserOptions: {
project: './tsconfig.json',
},
rules: {
'@typescript-eslint/prefer-nullish-coalescing': ['warn', { ignorePrimitives: true }],
},
},
],
};
3 changes: 2 additions & 1 deletion build/command/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

39 changes: 31 additions & 8 deletions build/continuous-deploy-fingerprint/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 8 additions & 3 deletions build/fingerprint-post/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 8 additions & 3 deletions build/fingerprint/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 10 additions & 4 deletions build/preview-build/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion build/preview-comment/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 9 additions & 4 deletions build/preview/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 5 additions & 2 deletions build/setup/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Binary file modified bun.lockb
Binary file not shown.
5 changes: 4 additions & 1 deletion ncc.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,10 @@ async function prebuild() {
await fs.promises.rm(buildDir, { force: true, recursive: true });
await fs.promises.rm(modulesDir, { force: true, recursive: true });

await spawn('bun', ['install', '--frozen-lockfile'], { stdio: 'inherit', env: { ...process.env, CI: true } });
await spawn('bun', ['install', '--frozen-lockfile'], {
stdio: 'inherit',
env: { ...process.env, CI: true },
});

console.log();
}
Expand Down
12 changes: 3 additions & 9 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,12 @@
"@tsconfig/node20": "^20.1.2",
"@types/jest": "^29.2.5",
"@types/node": "^16.18.11",
"@types/semver": "^7.5.8",
"@types/uuid": "^9.0.3",
"@vercel/ncc": "^0.36.0",
"conventional-changelog-conventionalcommits": "^5.0.0",
"eslint": "^8.54.0",
"eslint-config-universe": "^12.0.0",
"eslint-config-universe": "^13.0.0",
"getenv": "^1.0.0",
"jest": "^29.3.1",
"jest-snapshot-prettier": "npm:prettier@^2.8.8",
Expand All @@ -57,15 +58,8 @@
"trustedDependencies": [
"sqlite3"
],
"eslintConfig": {
"extends": "universe/node",
"ignorePatterns": [
"build/**",
"node_modules/**"
]
},
"prettier": {
"printWidth": 120,
"printWidth": 100,
"tabWidth": 2,
"singleQuote": true,
"bracketSameLine": true,
Expand Down
4 changes: 2 additions & 2 deletions src/actions/command.ts
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
import { getInput, info, setFailed } from '@actions/core';

import {
BuildInfo,
appPlatformDisplayNames,
appPlatformEmojis,
BuildInfo,
easBuild,
getBuildLogsUrl,
parseCommand,
projectInfo,
projectOwner,
} from '../expo';
import { createIssueComment, createReaction, issueComment, Reaction } from '../github';
import { Reaction, createIssueComment, createReaction, issueComment } from '../github';
import { template } from '../utils';
import { executeAction } from '../worker';

Expand Down
Loading

0 comments on commit ba9ed07

Please sign in to comment.