Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add readme for preview-build and fingerprint action #232

Merged
merged 10 commits into from
Sep 20, 2023

Conversation

Kudo
Copy link
Contributor

@Kudo Kudo commented Sep 18, 2023

following up with #231 (review) to add READMEs

@Kudo Kudo requested a review from byCedric September 18, 2023 18:16
Copy link
Member

@byCedric byCedric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks for adding these. Created a few comments with suggestions 😄

fingerprint/README.md Outdated Show resolved Hide resolved
permissions:
# REQUIRED: Allow comments of PRs
pull-requests: write # Allow comments on PRs
# REQUIRED: Allow updating fingerprint in acton caches
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for being explicit in these # REQUIRED parts 😄

fingerprint/README.md Outdated Show resolved Hide resolved
fingerprint/README.md Outdated Show resolved Hide resolved
- uses: actions/github-script@v6
if: ${{ github.event_name == 'pull_request' && github.steps.fingerprint.outputs.fingerprint-diff == '[]' }}
with:
script: |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be awesome if we could add a script for users to reuse since it might clutter their workflow a bit.

For now, I think it's fine.

preview-build/README.md Outdated Show resolved Hide resolved
preview-build/README.md Outdated Show resolved Hide resolved
fingerprint/README.md Show resolved Hide resolved
preview-build/README.md Show resolved Hide resolved
fingerprint/README.md Outdated Show resolved Hide resolved
preview-build/README.md Outdated Show resolved Hide resolved
preview-build/README.md Outdated Show resolved Hide resolved
preview-build/README.md Outdated Show resolved Hide resolved
Co-authored-by: Cedric van Putten <me@bycedric.com>
Base automatically changed from kudo/preview-build to main September 20, 2023 16:40
@Kudo Kudo merged commit acc171b into main Sep 20, 2023
12 checks passed
@Kudo Kudo deleted the kudo/preview-build-readme branch September 20, 2023 16:41
expo-bot pushed a commit that referenced this pull request Nov 24, 2023
## [8.1.0](8.0.0...8.1.0) (2023-11-24)

### New features

* add fingerprint integration ([#231](#231)) ([e6622e0](e6622e0))
* add readme for preview-build and fingerprint action ([#232](#232)) ([acc171b](acc171b)), closes [/github.com//pull/231#pullrequestreview-1628540314](https://github.com/expo//github.com/expo/expo-github-action/pull/231/issues/pullrequestreview-1628540314)
* **preview:** add update manifest permalinks to the output ([#245](#245)) ([331a5ab](331a5ab))

### Bug fixes

* **preview:** allow multiple `app.json` schemes ([#244](#244)) ([42d64cf](42d64cf))

### Code changes

* update error handling to node 20 standards ([#243](#243)) ([65ee055](65ee055))
* update workflows and repository to use Bun ([#241](#241)) ([7f1c170](7f1c170))
* upgrade all actions to run on node 20 ([#242](#242)) ([b3e5355](b3e5355))

### Other chores

* **ci:** update release flow with new service account ([#238](#238)) ([e289d93](e289d93))
* update release workflow actions ([#239](#239)) ([57dcabe](57dcabe))

### Documentation changes

* add link to breaking change pull request ([9e1a8c8](9e1a8c8))
* fix changelog link in readme ([185932d](185932d))
* update example to use `eas-version` ([#222](#222)) ([7bc946c](7bc946c))
@expo-bot
Copy link

🎉 This PR is included in version 8.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants